Executor graph#21
Merged
loloxwg merged 18 commits intoKipData:devfrom Jul 12, 2023
Merged
Conversation
…the two levels of Schema and DataBase for simplification
…d generation to avoid third-party dependencies
…tion Simpler Catalog implementation
- Configure Gpt code review bot.
* style(fmt): code format * feat(binder): add create table binding * feat(style): make code clean --------- Co-authored-by: Xwg <xuanwei.zhang@gatech.com>
…rint it (KipData#17) - add create table bind test - change logic of main function Co-authored-by: Xwg <xuanwei.zhang@gatech.com>
- catalog 存储了库表列之间的关系结构 - types 类型系统表示了数据库字段的类型
- 更改函数签名中的&String到&str - 取消类型中的new方法，并将其归入ColumnDesc 的new 方法中统一实现
- binder用来将解析后生成的 AST 和 Schema 信息绑定起来，检查输入的名称是否合法、是否有重复、有歧义 - catalog引入锁机制，创建column catalog流程改变 - 类型系统变化为sqlparser的DataTypeKind，并实现DataTypeExt trait，方便进行nullable设置
Closed
KKould
approved these changes
Jul 10, 2023
Member
KKould
left a comment
KKould
left a comment
There was a problem hiding this comment.
At present, only 'src/execution/parallel/pipeline_builder.rs' has a test case, other methods and files currently seem to be conceptual or difficult to understand, as a simple framework I think it looks fine, but we can use the test case improvement as an issue to improve to ensure that each unit is operational
Member
agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
simple executor graph.